Skip to content

API tokens API support #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 15, 2023
Merged

API tokens API support #461

merged 8 commits into from
Dec 15, 2023

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Dec 12, 2023 •
edited
Loading

This patch enables API-token management though the CLI as well as implements its use in the controlplane.

An API-token is an alternative authentication method compared to the temporary user auth.

  • [API] Load/validate API tokens in middleware alongside regular user auth tokens
  • [API] Implement API handlers for the creation, revocation and listing of API tokens in the client
  • [CLI] Add support to providing the token in the CLI via flag --token or env var CHAINLOOP_API_TOKEN
  • [CLI] Add support for creation, revocation and listing of tokens in the CLI

Closes #351
Closes #453

@migmartri
feat: API token support
be9cbc3 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
feat: API token support
d05c33d 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
feat: API token support
9b8d01b 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
feat: API token support
31a83f4 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
feat: API token support
4eb0348 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
feat(CLI): token management
1065776 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri marked this pull request as ready for review December 12, 2023 23:01
@migmartri
feat(CLI): token management
054a46b 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
danoo
danoo approved these changes Dec 14, 2023
View reviewed changes
Copy link

@danoo danoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the call and reviewing it together. LGTM! Please add an issue to make sure we track the user who created it. And also can we extract the revokedAt validation to a separated method?

danlishka
danlishka approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the call and reviewing it together. LGTM! Please add an issue to make sure we track the user who created it. And also can we extract the revokedAt validation to a separated method?

@migmartri
feat(CLI): token management
4a0e371 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri mentioned this pull request Dec 15, 2023
Closed
@migmartri migmartri merged commit df8e477 into chainloop-dev:main Dec 15, 2023
@migmartri migmartri deleted the api-token-api branch December 15, 2023 08:47
@migmartri migmartri mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlishka danlishka danlishka approved these changes

@buccarel buccarel Awaiting requested review from buccarel

+1 more reviewer

@danoo danoo danoo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controlplane API tokens support Service account support
3 participants
@migmartri @danlishka @danoo